From 253df8c02e4be56838cdd8c1ad17601c90b9b570 Mon Sep 17 00:00:00 2001 From: James Panther <4462786+jpanther@users.noreply.github.com> Date: Thu, 19 Aug 2021 11:49:20 +1000 Subject: [PATCH] =?UTF-8?q?=F0=9F=93=9D=20Add=20contributing=20guidelines?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- CONTRIBUTING.md | 53 +++++++++++++++++++++++++++++++++++++++++++++++++ README.md | 16 ++++++++------- 2 files changed, 62 insertions(+), 7 deletions(-) create mode 100644 CONTRIBUTING.md diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md new file mode 100644 index 00000000..eeb176e2 --- /dev/null +++ b/CONTRIBUTING.md @@ -0,0 +1,53 @@ +## How to contribute to Congo + +### Bugs & other issues + +#### Found a bug? 🐛 + +- **Ensure the bug has not already been reported** by searching [GitHub Issues](https://github.com/jpanther/congo/issues). If there's already an open issue, feel free to add any extra information you might have about the issue. +- If you're unable to find an open issue matching the problem, [open a new one](https://github.com/jpanther/congo/issues/new). Be sure to include a **title and clear description**, as much relevant information as possible, and a **code sample**, **screenshot**, or a **test case** demonstrating the expected behavior that is not occurring. +- Where possible, use the bug report templates to create the issue. Avoid including descriptions like "bug", "feature", etc in the issue title as these will be handled by labels. + +#### Have a patch that fixes an issue? + +- Great! Open a new GitHub pull request with the patch. +- All development occurs on the `dev` branch and new PRs should be forked from here. +- The command `npm run example` can be used to test local changes using the example site. +- Ensure the PR description clearly describes the problem and solution. Include the relevant issue number, if applicable. +- **Before submitting**, check the [coding conventions](#coding-conventions) section below to learn more about coding and commit message expectations. + +### New features & enhancements + +#### Do you intend to add a new feature, or change an existing one? + +- Enhancements are welcome but before implementing any features, be sure to suggest your change by opening a [new discussion](https://github.com/jpanther/congo/discussions/new) about your idea. Enhancements are discussed to ensure they fit with the project's design intent and overall roadmap. +- Before opening a discussion, [check to see](https://github.com/jpanther/congo/discussions/categories/ideas) if a similar idea is already being discussed. +- All ideas and suggestions are welcome and will be judged on their merits. +- If the community supports your idea, go ahead and submit a PR with the implemented feature. + +### Questions? 🙋‍♀️ + +- If you have a general question, these should be asked using [GitHub Discussions](https://github.com/jpanther/congo/discussions). Feel free to open a [new discussion](https://github.com/jpanther/congo/discussions/new) to ask your question using the "Q&A" category. +- Be sure to check if your question has already been answered by searching [existing Q&A discussions](https://github.com/jpanther/congo/discussions/categories/q-a). + +### Coding conventions + +- Indent using 2 spaces (soft tabs). +- Put spaces between list items (ie. `[1, 2, 3]`, not `[1,2,3]`), around operators (ie. `1 + 1`, not `1+1`) and inside go templating tags (ie. `{{< alert >}}`, not `{{}}`). +- Avoid code reuse in templates by extracting components into partials. +- Layout code in a logical manner that prioritises readibility. +- Add comments when the intent of the code isn't immediately apparent or to break up large blocks of logic. +- Use relative paths to assets without including the preceeding slash but, when referring to a folder, including a trailing slash (ie. `static/img/`, not `/static/img/` or `/static/img`). +- Any static text must be referenced using the `i18n` methods and included in the localisation assets. +- Commit often, preferring incremental changes rather than bundling everything into a single, large commit. + +The project includes a Prettier config that helps to format code in line with these guidelines. + +#### Commit message guidelines + +- Use [Gitmoji](https://gitmoji.dev) in commit messages to provide context and. +- Clearly describe the change with a short summary in the first 72 characters. +- Place more detailed explanations in paragraphs below the summary, separated by a blank line. +- Use imperative language (ie. "Fix bug", not "Fixed bug" or "Fixes bug"). +- Do not end the summary line with a period. +- Reference any issues fixed using their GitHub issue number. diff --git a/README.md b/README.md index 68c20e15..da88aefd 100644 --- a/README.md +++ b/README.md @@ -1,9 +1,11 @@ # Congo -Congo is designed to be a fast, lightweight theme for Hugo. It's based upon Tailwind CSS with a clean and minimalist design. +Congo is designed to be a simple, lightweight theme for [Hugo](https://gohugo.io). It's built using Tailwind CSS with a clean and minimalist design that prioritises to your content. 🌏 [Demo site](https://jpanther.github.io/congo/) -📑 [Theme documentation](https://jpanther.github.io/congo/docs/) +📑 [Theme documentation](https://jpanther.github.io/congo/docs/) +🐛 [Bug reports & issues](https://github.com/jpanther/congo/issues) +💡 [Questions & feature requests](https://github.com/jpanther/congo/discussions) ![Screenshot](https://raw.githubusercontent.com/jpanther/congo/stable/images/screenshot.png) @@ -139,10 +141,10 @@ Now whenever you make a change, the (non-minified) CSS files will be rebuilt aut Congo is still very much a work in progress. I intend to keep adding features and making changes as required. -### Bugs & Suggestions +Feel free to get in touch with any issues or suggestions for new features you'd like to see. -Feel free to get in touch with any issues or suggestions for new features you'd like to see. Please use GitHub issues for all bug reports and suggestions to help keep everything in one spot. +- 🐛 **Bug reports & issues:** Use [GitHub Issues](https://github.com/jpanther/congo/issues) +- 💡 **Ideas for new features:** Open a discussion on [GitHub Discussions](https://github.com/jpanther/congo/discussions) +- 🙋‍♀️ **General questions:** Head to [GitHub Discussions](https://github.com/jpanther/congo/discussions) -If you're able to fix a bug or implement a new feature, I welcome PRs for this purpose. - -All development occurs on the `dev` branch and new PRs should be forked from here. +If you're able to fix a bug or implement a new feature, I welcome PRs for this purpose. Learn more in the [contributing guidelines](https://github.com/jpanther/congo/CONTRIBUTING.md).