From 5ebc70ab3ab12b039d87afa794f1820299947402 Mon Sep 17 00:00:00 2001 From: James Panther <4462786+jpanther@users.noreply.github.com> Date: Sat, 25 Jun 2022 15:31:08 +1000 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20Fix=20external=20article=20link?= =?UTF-8?q?=20alignment=20and=20add=20RTL=20support?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- CHANGELOG.md | 2 ++ assets/css/compiled/main.css | 12 ++++++++---- layouts/partials/article-link.html | 7 ++++--- 3 files changed, 14 insertions(+), 7 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6be6a5bc..1bb53c5d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -22,6 +22,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), - Search link does not appear in header if main menu has no items to display - Search only returns results in the primary language when multiple languages are available ([#229](https://github.com/jpanther/congo/issues/229)) +- Arrow on external article links not aligned correctly when title wraps onto multiple lines +- Arrow on external article links points the wrong direction for RTL languages - Scroll to top misaligned with the footer at small viewport heights - Link to homepage would be incorrect in some deployments if `baseURL` contained sub-directories in the path diff --git a/assets/css/compiled/main.css b/assets/css/compiled/main.css index e8fdb807..8e7c6b64 100644 --- a/assets/css/compiled/main.css +++ b/assets/css/compiled/main.css @@ -1776,10 +1776,6 @@ body button { margin-top: 1.5rem; } -.-mt-2 { - margin-top: -0.5rem; -} - .mr-3 { margin-right: 0.75rem; } @@ -2530,6 +2526,10 @@ body button { left: -1.5rem; } +[dir="ltr"] .ltr\:ml-\[0\.1rem\] { + margin-left: 0.1rem; +} + [dir="ltr"] .ltr\:ml-2 { margin-left: 0.5rem; } @@ -2590,6 +2590,10 @@ body button { right: -1.5rem; } +[dir="rtl"] .rtl\:mr-\[0\.1rem\] { + margin-right: 0.1rem; +} + [dir="rtl"] .rtl\:mr-2 { margin-right: 0.5rem; } diff --git a/layouts/partials/article-link.html b/layouts/partials/article-link.html index 8916b312..4bf143ee 100644 --- a/layouts/partials/article-link.html +++ b/layouts/partials/article-link.html @@ -1,5 +1,5 @@
-

+

{{ with .Params.externalUrl }} {{ $.Title | emojify }} - ↗ + + {{ else }}