From f34a827cea380d7d67bd8932cdb8af6624f782d8 Mon Sep 17 00:00:00 2001 From: James Panther <4462786+jpanther@users.noreply.github.com> Date: Sun, 10 Sep 2023 10:38:54 +1000 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20Don't=20lazy=20load=20prominent?= =?UTF-8?q?=20images?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes: #591 --- CHANGELOG.md | 5 +++-- layouts/_default/single.html | 3 --- layouts/partials/home/profile.html | 7 ++----- layouts/partials/logo.html | 6 ------ 4 files changed, 5 insertions(+), 16 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f1710d29..efa7d53e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -23,8 +23,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), ### Fixed -- TypeError is output to console when viewing leaf pages ([#596](https://github.com/jpanther/congo/pull/596)) -- URL to Congo project in footer used deprecated git.io short link ([#605](https://github.com/jpanther/congo/pull/605)) +- Prominent images in content and site layout are lazy loaded ([#591](https://github.com/jpanther/congo/issues/591)) +- TypeError is output to console when viewing leaf pages ([#596](https://github.com/jpanther/congo/issues/596)) +- URL to Congo project in footer used deprecated git.io short link ([#605](https://github.com/jpanther/congo/issues/605)) - Various typos in the docs and example site ([#608](https://github.com/jpanther/congo/pull/608), [#609](https://github.com/jpanther/congo/pull/609), [#613](https://github.com/jpanther/congo/pull/613)) - Incorrect `render` value is used in the 'external' archetype ([#630](https://github.com/jpanther/congo/pull/630)) diff --git a/layouts/_default/single.html b/layouts/_default/single.html index 90c5110b..70e8fe88 100644 --- a/layouts/_default/single.html +++ b/layouts/_default/single.html @@ -31,9 +31,6 @@ {{ end }} {{ end }} alt="{{ $.Params.featureAlt | default $.Params.coverAlt | default "" }}" - {{ if $.Site.Params.enableImageLazyLoading | default true }} - loading="lazy" - {{ end }} /> {{ with $.Params.coverCaption }}
{{ . | markdownify }}
diff --git a/layouts/partials/home/profile.html b/layouts/partials/home/profile.html index 24fb6f63..77398f01 100644 --- a/layouts/partials/home/profile.html +++ b/layouts/partials/home/profile.html @@ -3,20 +3,17 @@ h-full {{ end }} flex flex-col items-center justify-center text-center" > -
+
{{ with .Site.Author.image }} {{ $authorImage := resources.Get . }} {{ if $authorImage }} {{ $authorImage := $authorImage.Fill "288x288 Center" }} {{ $.Site.Author.name | default {{ end }} {{ end }} diff --git a/layouts/partials/logo.html b/layouts/partials/logo.html index 1fefceb7..ee119168 100644 --- a/layouts/partials/logo.html +++ b/layouts/partials/logo.html @@ -9,9 +9,6 @@ height="{{ div $logo.Height 2 }}" class="max-h-[10rem] max-w-[10rem] object-scale-down object-left{{ if $logo_dark }} hidden dark:flex{{ end }}" alt="{{ .Site.Title }}" - {{ if .Site.Params.enableImageLazyLoading | default true }} - loading="lazy" - {{ end }} /> {{- if $logo_dark }} {{ .Site.Title }} {{- end}}