Merge c1d4f0c003 into bba8df99ac

🔀 Merge pull request #688 from jpanther/dependabot/github_actions/actions/setup-node-4
👷 Bump actions/setup-node from 3 to 4
2023-10-30 11:54:28 +08:00 · 2023-10-29 09:24:58 +11:00 · 2023-10-28 22:08:48 +00:00 · 2023-10-24 16:27:08 -05:00
3 changed files with 22 additions and 7 deletions
--- a/.github/workflows/build-theme.yml
+++ b/.github/workflows/build-theme.yml
@ -12,7 +12,7 @@ jobs:
        with:
          ref: "${{ github.head_ref }}"
      - name: Install dependencies and Build Theme
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
      - run: npm install
      - run: npm run assets
      - name: Commit and push Chart.js changes
--- a/layouts/partials/functions/warnings.html
+++ b/layouts/partials/functions/warnings.html
@ -7,3 +7,6 @@
 {{ if ne .Params.logo nil }}
  {{ warnf "[CONGO] Theme parameter `logo` has been renamed to `header.logo`. Please update your site configuration." }}
 {{ end }}
+{{ if eq .Params.header.logo .Params.header.logo_dark }}
+  {{-  warnf "[CONGO] Interactions with a single resource via multiple distinct resource handles can be problematic. It is recommended to only declare `header.logo_dark` when it is distinct from `header.logo`." }}
+{{- end }}
--- a/layouts/partials/logo.html
+++ b/layouts/partials/logo.html
@ -5,17 +5,29 @@
    <a href="{{ "" | relLangURL }}" class="mr-2">
      <img
        src="{{ $logo.RelPermalink }}"
+        {{- if eq $logo.MediaType.SubType "svg" }}
+          width="25"
+          height="25"
+          class="m-0 p-0 object-scale-down object-left{{ if $logo_dark }} hidden dark:flex{{ end }}"
+        {{- else }}  
          width="{{ div $logo.Width 2 }}"
          height="{{ div $logo.Height 2 }}"
          class="max-h-[10rem] max-w-[10rem] object-scale-down object-left{{ if $logo_dark }} hidden dark:flex{{ end }}"
+        {{- end }}  
        alt="{{ .Site.Title }}"
      />
      {{- if $logo_dark }}
      <img
        src="{{ $logo_dark.RelPermalink }}"
+        {{- if eq $logo_dark.MediaType.SubType "svg" }}
+          width="25"
+          height="25"
+          class="m-0 p-0 object-scale-down object-left{{ if $logo }} !dark:hidden{{ end }}"
+        {{- else }}
          width="{{ div $logo_dark.Width 2 }}"
          height="{{ div $logo_dark.Height 2 }}"
-        class="max-h-[10rem] max-w-[10rem] object-scale-down object-left dark:hidden"
+          class="max-h-[10rem] max-w-[10rem] object-scale-down object-left{{ if $logo }} !dark:hidden{{ end }}"
+        {{- end }}
        alt="{{ .Site.Title }}"
      />
      {{- end}}
Author	SHA1	Message	Date
Wolf Noble	92172c1a58	Merge `c1d4f0c003` into `bba8df99ac`	2023-10-30 11:54:28 +08:00
James Panther	bba8df99ac	🔀 Merge pull request #688 from jpanther/dependabot/github_actions/actions/setup-node-4 👷 Bump actions/setup-node from 3 to 4	2023-10-29 09:24:58 +11:00
dependabot[bot]	c96582cf47	👷 Bump actions/setup-node from 3 to 4 Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3 to 4. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](https://github.com/actions/setup-node/compare/v3...v4) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>	2023-10-28 22:08:48 +00:00
Wolf Noble	c1d4f0c003	[SVG_Logo_support] add logic brace around img dimension math, so as to support SVGs. Add warning discouraging specifying the same asset as both logo and logo_dark.	2023-10-24 16:27:08 -05:00